fix: Changing dtype lowercasing to start of athena2pyarrow function #3122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMy777
changed the title
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kukushking
approved these changes
Apr 4, 2025
jaidisido
approved these changes
Apr 4, 2025
|
Hello there 👋. With this change my nested fields stopped working properly. Example: It's like this old issue #2357 Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Because of a bug, we cannot send an uppercase
dtypeparameter to the athena2pyarrow function.This is due to the fact that this snippet happens prior to lowercasing the
dtypevariable -I changed the order to make the dtype parameter lowercased before entering this condition, thus even an uppercased ARRAY/STRUCT/MAP type will initialize the orig_dtype variable and avoid the bug.
Relates
#3121
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.